Repository navigation
fix(ingest): cap decompression, harden envelope parsing, fix fingerprinting - #353
Merged
Merged
Conversation
…rprint grouping - cap gzip/deflate output via Read::take (zip bomb), cap attachment count/size - overflow-safe bounds checks, honour declared item length - case-insensitive Content-Encoding - fingerprint: use last exception, fall back to last frame, tag components, normalize numbers/ids in messages Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Caps gzip/deflate decompression and attachment count/size on ingest, makes envelope item bounds checks overflow-safe, and fixes several fingerprint grouping bugs.
Why
Closes #330
Refs #337 (partially fixed; remaining items under Deferred, so not auto-closed)
A ~1 MB gzip could previously expand without bound and OOM-kill the process.
How
EnvelopeLimits(defaults: 32 MiB decompressed, 16 attachments, 20 MiB per attachment) plusparse_envelope_with_limits;parse_envelopeuses the defaults, soserver.rsis untouched.Read::take(max + 1); nolen * 2preallocation;Content-Encodingmatched case-insensitively (alsox-gzip).checked_addfor item bounds; text items honour declared length when it ends at a newline or EOF, otherwise fall back to newline scan (tolerates miscounting SDKs).function:/file:tagged components, numbers/hex ids/UUIDs normalised in messages.Testing
cargo test --workspacepassescargo fmt --all -- --checkpassescargo clippy --workspace --all-targets -- -D warningspassesDeferred (not fixed, #337 remains partly open)
event.fingerprint(needs a newEventfield touching many struct literals).events[0], transactions/sessions persisted before channel send, empty response body (should be{"id":...}), noisy per-requesttracing::info!(all inserver.rs).🤖 Generated with Claude Code