Repository navigation
fix(mcp): JSON-RPC 2.0 and MCP spec compliance - #350
Merged
Merged
Conversation
- notifications (no id) get no response; batches supported - validate jsonrpc/id/method/params; codes -32600/-32601/-32602 - negotiate protocolVersion on initialize - tool failures returned as isError results; unknown tool is -32602 - async stdin/stdout, remove unwrap, char-safe key abbreviation Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #336
What
id) get no response; batch arrays supported (empty batch -> -32600, all-notification batch -> no output)jsonrpc == "2.0",idtype,method,params; error codes -32700/-32600/-32601/-32602initializenegotiatesprotocolVersion(2025-06-18, 2025-03-26, 2024-11-05)tools/callfailures returnisError: truecontent; unknown tool is -32602unwrap(), char-boundary-safe key abbreviation (no panic on short/multibyte keys)handle_messagenow returnsOption<String>Why
Strict MCP clients broke on non-compliant JSON-RPC behavior (responses to notifications, wrong error codes, no batch support, no version negotiation). Fixes all gaps listed in #336. Deferred: none.
Testing
Failing tests added first (mcp_test.rs plus unit tests).
cargo fmt --check,cargo clippy --workspace --all-targets -- -D warningsandcargo test --workspaceall pass (mcp: 2 unit + 16 integration).🤖 Generated with Claude Code