Repository navigation
fix(ingest): accept sentry_key query param auth (#327) - #345
Merged
Merged
Conversation
Modern Sentry JS SDKs send auth as ?sentry_key=...&sentry_version=7 instead of
X-Sentry-Auth. Header/Bearer still take precedence; query param is a fallback.
Header parser now tolerates whitespace around separators. Successful ingest
responds with {"id":"<event_id>"}.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Resolves RUSTSEC-2026-0285 (rustls TLS 1.3 handshake) and the devalue, source-map-js and undici advisories that fail the Security workflow. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ingest accepts
?sentry_key=as an auth fallback (order:x-sentry-auth,Authorization: Bearer, query).X-Sentry-Authparsing tolerates whitespace around,and=. A successful envelope now returns{"id":"<event_id>"}instead of an empty body.Why
Modern Sentry JS SDKs send auth as query params and were rejected with 401. Fixes #327.
Testing
Integration tests: header auth (with/without spaces), query auth plus JSON id, wrong/empty/missing key returns 401, header precedence. Parser unit test for whitespace.
cargo test -p trapfalld -p trapfall_ingestand clippy pass. Not tested against a real JS SDK. Cargo/npm Audit failures are pre-existing on develop.🤖 Generated with Claude Code