Repository navigation
fix(proto): accept numeric epoch timestamps on Event and Breadcrumb - #344
Merged
Merged
Conversation
Real Sentry JS/Python SDKs send epoch int/float timestamps; the Option<String> field made envelope parsing fail and drop the event. Add tolerant deserialize_timestamp (string, i64, f64) normalizing to RFC3339 so storage is unchanged. Fixes #309 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Resolves RUSTSEC-2026-0285 (rustls TLS 1.3 handshake) and the devalue, source-map-js and undici advisories that fail the Security workflow. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
New
deserialize_timestampintrapfall-protoused forEvent.timestampandBreadcrumb.timestamp. Accepts RFC3339 string, i64 or f64 epoch seconds; numbers are normalized to an RFC3339 UTC string, so storage is unchanged.Why
Real Sentry JS/Python SDKs send numeric epoch timestamps. The
Option<String>fields failed to deserialize, so the envelope parser dropped the event while the SDK still got HTTP 200. Refs #309 (the transaction parser still rejects RFC3339 string timestamps; that half remains open).Testing
Unit tests for float, int, string, null/missing, breadcrumb, and a full envelope with numeric event and breadcrumb timestamps.
cargo test -p trapfall_proto -p trapfall_ingestpass. Not yet validated against payloads captured from real SDKs (#299). Cargo/npm Audit failures are pre-existing on develop.🤖 Generated with Claude Code