Skip to content

chore: CLAUDE.md convention drift (println!, unwrap/expect, channel sizes) #338

Description

@ajianaz
  • println! in lib module crates/trapfalld/src/migrate.rs:108,180,199-219 (route via tracing or move to main).
  • unwrap() at crates/trapfall-mcp/src/lib.rs:24 and crates/trapfalld/src/server.rs:1021; expect at main.rs:128; process::exit(1) at main.rs:182.
  • list_issues (page - 1) * limit can overflow (server.rs:538): use saturating math.
  • Pipeline sizes differ from CLAUDE.md (mpsc 256 / batch 16 / broadcast 64): code is 1024 / 50 / 256. Align code or update the docs.
  • Verify main.rs uses current_thread runtime as documented.
  • Migration numbering differs between SQLite (timestamps) and Postgres (001-005).

Found in static audit of develop @ db3ca67.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    clean-codeDRY / clean code improvementpriority:lowP3 - Nice to have

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions