Repository navigation
chore(ci): raise the Cora Review job timeout from 10 to 30 minutes - #411
Merged
Merged
Conversation
Diffs of a few hundred lines already exceed the 10-minute limit: the job is cancelled mid-review and no verdict is posted, which blocks the merge gate (seen three times on #407). Sync the stated limit in AGENTS.md and CONTRIBUTING.md.
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Raises
timeout-minuteson the Cora Review job from 10 to 30. Updates the limit stated in AGENTS.md and CONTRIBUTING.md to match.Why
10 minutes is too short for diffs of a few hundred lines. When the job hits the limit it is cancelled in the middle of the review, and Cora posts "Review could not complete" instead of a verdict. A real verdict is required before merge, so the PR is blocked. #407 (12 files, about 620 lines) has hit this three times on two different commits. Reviews of 850+ lines take about 16 minutes, so 30 leaves headroom.
Changes
.github/workflows/cora-review.yml:timeout-minutes: 30, with a comment explaining why.AGENTS.md§2 andCONTRIBUTING.md: the stated Cora Review limit is now 30 minutes. The advice to split large change-sets stays.Testing
pull_request, so this PR's own Cora Review job already uses the new timeout.cora review --staged --ci --severity major: no issues found.