Repository navigation
test(cli): real-binary E2E for the child handoff and verify gate (#383, 3/3) - #398
Merged
Merged
Conversation
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Part 3 of 3 of the child-agent handoff: the real-binary integration test from the issue's testing section.
Why
#383. The wiring merged in #397 is covered by unit tests; this proves the whole path with real child processes.
Changes
tests/child_handoff_e2e.rs(test only): the test plays the parent model withAgentStartTool/AgentPollTooland starts realtolechildren through a wrapper that pins a scripted mock provider and a no-oputeke(hermetic: the real memory store is never touched).implementchild submits a handoff whose verification failed:agent_pollreportsverify_failed(not closed) with a fix prompt naming the command and the artifact;fixchild started from that prompt reads the artifact by reference with its own file tool (the mock only lets it reportsaw artifactif it received the file body), submits passing verification:closed, no fix prompt;implementchild that closes without any handoff isunverified.Testing
Refs #383