Repository navigation
feat(cli): tole doctor full tier — chat, streaming and a real tool-call loop (#378, 2/3) - #390
Merged
Merged
Conversation
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Part 2 of 3 of
tole doctor: thefulltier. Builds on the offline and catalog tiers merged in #388.Why
#378. A
fullgreen is the machine-checkable gate for "ready to release" claims: the provider must actually chat, stream and complete a tool-call loop, not just answer/models.Changes
doctor.rs:fulltier = three real calls through the real turn loop (run_turn+OpenAiProvider): a plain chat, a streamed chat, and a tool-call loop where the model must call a ReadOnly probe tool with the expected marker and the loop must settle on a final answer. Each failure is classified (chat/stream/tools) with a fix command; the model answering without calling the tool is reported as such.main.rs:--tier full.tole doctor --tier fullmust exit 0), CHANGELOG.Testing
tools, reached = catalog), broken completions (blocker atchat).Refs #378