Repository navigation
fix(core,cli): unknown wire messages count is null, empty read_file path rejected - #360
Merged
Merged
Conversation
…ath rejected Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two small fixes found by the pre-tag scan for v0.8.1, plus the CHANGELOG entry under
[0.8.1].Why
usage_reportfabricatedmessages: 0when the field was absent, contradicting the module's "unknown is never a measured zero" contract (status JSON consumers saw a false 0).read_filewith an emptypathjoined to the jail root and failed with a confusing "is a directory" error.Changes
crates/tole-cli/src/usage_report.rs:WirePoint.messagesisOption<u64>, serialized asnullwhen unknown; new testmissing_messages_is_unknown_not_zero.crates/tole-core/src/read_file.rs: empty path rejected withread_file: path is empty; new testrejects_empty_path.CHANGELOG.md:### Fixedunder[0.8.1].Testing
cargo fmt,clippy -D warningsandcargo test --workspacepass locally; CI runs all profiles.🤖 Generated with Claude Code