Repository navigation
refactor(web): adopt shadcn form controls in schedules, accounts, comments - #260
Merged
Merged
Conversation
…ments Following #230/#231, replace the remaining raw form controls in admin pages with shadcn/ui components: - Schedules: filter search + date-range inputs, create/edit modal datetime inputs, image/carousel URL inputs, and the bundle-item select + textarea now use shadcn Input/Select/Textarea; drop the legacy form-input classes still attached to already-adopted Textareas - Accounts: Add Account form fields (user ID, username, access token, expiry, app ID/secret) now use shadcn Input - Comments: search field now uses shadcn Input - remove CSS orphaned by the swap: the mobile .form-group:has(> input[type='date']) grid rule (redundant default span) and .carousel-url-row .form-input, the latter replaced with :global(input) so the flex layout still applies to the component - custom non-form elements (thumbnail lightbox buttons, calendar cell buttons, sidebar hamburger, OAuth connect button) intentionally stay as-is Raw form controls in admin routes are now zero. svelte-check matches the pre-existing baseline (1 known process typing error, 36 warnings); vite build passes.
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Continues the shadcn/ui adoption line from #230 (Settings rebuild) and #231 (DataTable/StatusBadge consistency). After those landed, a static scan showed the remaining raw form controls (
<input>/<select>/<textarea>with legacyform-inputclasses) were concentrated in three admin pages. This PR finishes the form-control adoption so all admin pages build forms from the same design system.Changes
Schedules
InputInput<select>→Select.Root, caption<textarea>→Textarea, bundle image URL →InputInputclass="form-input"from the already-adoptedTextareausages (caption, edit caption, reject reason)Accounts
InputComments
InputCSS cleanup (Schedules)
.form-group:has(> input[type='date'])mobile grid rule — it only set the defaultgrid-column: span 1, and the:has(> input)child no longer survives Svelte scoping now thatInputis a component.carousel-url-row .form-input→.carousel-url-row :global(input)so theflex: 1rule keeps applying to the component-rendered inputIntentionally untouched: custom non-form interactive elements (thumbnail lightbox buttons, calendar
cal-itembuttons, sidebar hamburger/backdrop/logout, OAuth connect button, hidden file input inside the Media upload button).Verification
vite buildpasses (exit 0)svelte-check: 1 error / 36 warnings — identical to the pre-change baseline (the single error is the pre-existingprocesstyping issue inhooks.server.ts, unrelated)