Skip to content

chore: lock release and Docker builds to Cargo.lock - #50

Merged
ajianaz merged 1 commit into
developfrom
chore/locked-release-builds
Oct 15, 2026
Merged

ajianaz merged 1 commit into
developfrom
chore/locked-release-builds

Conversation

@ajianaz

@ajianaz ajianaz commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Description

Ref #48 (lockfile half): adds --locked to every dependency-resolving cargo invocation in the release pipeline and Docker builds, matching what CI already does since #46 — a release or image build can no longer resolve different dependencies than CI tested.

Type

  • chore — Maintenance, CI, etc.

Changes

  • .github/workflows/release.yml: cargo build --release --locked --target … -p covecto -p covecto-api
  • Dockerfile: --locked on the dependency pre-build step and the final cargo build --release --locked --bin covecto (the Dockerfile already copies Cargo.toml + Cargo.lock before sources, so the lockfile is present and layer caching is unchanged; .dockerignore does not exclude it)
  • Dockerfile.binaries: no change needed — it only copies pre-built binaries, no cargo step
  • Deliberately out of scope: cargo publish lines in release.yml (would need --allow-dirty interaction review; can be a follow-up)

Testing

  • cargo build --release --locked -p covecto-core — clean locally (6m18s)
  • Docker builds not runnable on this headless host — stated honestly rather than assumed; CI on this PR exercises the workflow YAML path
  • CI gates green on this PR

Related Issues

Ref #48

Checklist

  • Branch from develop
  • Conventional commits
  • No secrets or credentials

Ref #48

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@ajianaz
ajianaz merged commit 0f0eff5 into develop Oct 15, 2026
7 checks passed
ajianaz added a commit that referenced this pull request Oct 15, 2026
Fixed:
- Streaming path (vectorize_to) now applies SVG optimization when
  optimize=true; it was silently skipped (#43)
- PixelExact streaming metadata: svg_byte_size off-by-one and
  path_count double-counting translucent paths (#47)

Changed:
- CI, release workflow and Dockerfile build with --locked; Cargo.lock
  synced with the workspace version (#46, #50)
- Parity test vectorize()/vectorize_to() hardened: 58 cases, config
  matrix, ground-truth counter assertions (#47, #49)

Co-authored-by: ajianaz <ajianaz@users.noreply.github.com>
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant