Repository navigation
fix(cli): point help to agent mode and stop printing env secrets in --help - #669
Merged
Merged
Conversation
…-help Signed-off-by: ajianaz <ajianaz@users.noreply.github.com>
ajianaz
added a commit
that referenced
this pull request
Oct 16, 2026
## What Move the two `[Unreleased]` entries (help points to agent mode; `--help` no longer prints env secrets, both from #669) into the `[0.19.0]` section. `[Unreleased]` is empty again. No code, version or link changes. ## Why v0.19.0 is not tagged yet, so everything merged since the bump belongs in it. ## Testing - Docs-only. `CHANGELOG.md` diff checked: only the two entries moved; the `[0.19.0]` and `[Unreleased]` headings and the compare links are unchanged. Signed-off-by: ajianaz <ajianaz@users.noreply.github.com> Co-authored-by: ajianaz <ajianaz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
cora --help,cora review/scan --help,cora mcp --helpandcora install --helpnow say how to review without an LLM key:--no-llm, the agent-as-reviewer MCP tools (cora.review_prepare/review_finalize,cora.scan_prepare/scan_finalize), the/cora-reviewskill, andclaude mcp add cora -- cora mcpfor Claude Code.docs/cli-reference.mdgets the same rows.--api-key(CORA_API_KEY) and--token(GITHUB_TOKEN) hide their environment value in help. clap prints[env: NAME=value]by default, socora --helpwith a key in the environment printed the key (found while checking the help text).Why
Agent mode shipped in v0.19.0 with docs but no pointer from the CLI itself, and a user who runs
--helpin CI or a shared terminal must not see their key.Testing
cargo fmt --check,cargo clippy --all-targets --features tree-sitter -- -D warnings,cargo test --features tree-sitter(1258 unit + 20 CLI tests). New CLI tests:mcp --helpexplains agent-as-reviewer,install --helpmentions the skill,review/scan --helppoint to--no-llmandcora mcp --help, and--help/review --help/upload-sarif --helpnever print aCORA_API_KEYorGITHUB_TOKENset in the environment.claude -p, cora MCP with no key) on the final build: prepare, judge, finalize works end to end.