Repository navigation
fix(mcp): report capped deterministic findings to the agent (not_shown) - #659
Merged
Merged
Conversation
review_prepare listed all deterministic findings but review_finalize showed only rules_engine.max_findings of them with no explanation, found by running a real agent on a real project. prepare now reports the total and the cap; finalize, scan_finalize and review_diff report not_shown. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: ajianaz <ajianaz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
cora.review_preparelists every deterministic finding, butcora.review_finalizeshows onlyrules_engine.max_findings(default 5) of them and said nothing about the rest. Now:review_preparereturnsdeterministic_findings_totaland a note about the cap.review_finalize,scan_finalizeandcora.review_diffreturnnot_shown(and a note naming the setting).Why
Found by running a real agent (
claude -p, cora with no LLM) on a real project (uteke, commit09fb50b, a 25 KB security-sensitive diff): prepare reported 8 findings, finalize returned 5, and the agent could not explain the gap (3bug-unwraphits were silently capped). The CLI already warns on stderr; the MCP tools did not.Testing
cargo fmt --check,cargo clippy --all-targets --features tree-sitter -- -D warnings,cargo test --features tree-sitter(1212 passed; new: 7 TODO findings, cap 5 → total 7, shown 5,not_shown2).