Repository navigation
fix(security): SARIF no-judge marker cannot be forged or missed - #658
Merged
Merged
Conversation
A model-written summary containing the marker sentence is stripped, and the judge-failure fallback now carries the marker. Documents the block_in_place multi-thread requirement of the MCP block_on helper. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: ajianaz <ajianaz@users.noreply.github.com>
A single replace pass let a nested marker reassemble after removal. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: ajianaz <ajianaz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes the two low items left open by the audit of #650–#657.
cora.judge = "none") is detected from the summary text. A model-written summary containing that sentence could forge it, and the judge-failure fallback (deterministic findings only) was never marked. The sentence is now stripped from model-written summaries (also on cache hits) and added to the fallback summary.block_onhelper needs the multi-thread runtime the server uses (block_in_placepanics oncurrent_thread; a thread hand-off would needSendfutures, which the pipeline's futures are not).Why
cora.judge = "none"is what stops an empty SARIF file from being read as "reviewed and clean", so it must be set exactly when no model judged.Testing
cargo fmt --check,cargo clippy --all-targets --features tree-sitter -- -D warnings,cargo test --features tree-sitter(1210 passed; new: forged marker stripped, fallback marked).