Skip to content

fix: release workflow changelog sed mismatch (v prefix) - #65

Merged
ajianaz merged 1 commit into
developfrom
fix/release-changelog-extract
Jun 1, 2026
Merged

ajianaz merged 1 commit into
developfrom
fix/release-changelog-extract

Conversation

@ajianaz

@ajianaz ajianaz commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Problem

Release notes for v0.1.3 were empty because the workflow sed pattern looked for ## [v0.1.3] but CHANGELOG uses ## [0.1.3] (no v prefix).

Fix

  • Extract two outputs: TAG (v0.1.3) for display/asset names, VERSION (0.1.3) for changelog sed match
  • All printf references use TAG, only the sed pattern uses VERSION

Impact

Next release (v0.1.4+) will have correct changelog in release notes.

@coderabbitai

coderabbitai Bot commented Jun 1, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@ajianaz, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 41 minutes and 50 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2de3468f-2418-4945-8b3d-f7424ed82c8f

📥 Commits

Reviewing files that changed from the base of the PR and between 680e152 and 742a53c.

📒 Files selected for processing (1)
  • .github/workflows/release.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-changelog-extract

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ajianaz
ajianaz force-pushed the fix/release-changelog-extract branch from 2b68689 to 8e03c0f Compare June 1, 2026 01:29
@github-actions

github-actions Bot commented Jun 1, 2026 •

Copy link
Copy Markdown

🔍 Cora AI Code Review

❌ Blocked — critical issues found.

🔴 Error (1)

  • .github/workflows/release.yml:143 — While the VERSION output is validated as semver, the sed command on line 143 uses ${{ steps.version.outputs.VERSION }} which is a GitHub Actions expression expanded BEFORE the shell runs. Although the semver validation mitigates injection here, the validation happens in a different step. If someone modifies the workflow and breaks the dependency ordering, the sed pattern becomes injectable. Consider also escaping or validating within the same step, or using an environment variable passed between steps instead of template expansion.

Review powered by cora-cli · BYOK · MIT

@ajianaz
ajianaz force-pushed the fix/release-changelog-extract branch from 8e03c0f to 742a53c Compare June 1, 2026 01:30
@ajianaz
ajianaz merged commit 45717a1 into develop Jun 1, 2026
8 checks passed
@ajianaz
ajianaz deleted the fix/release-changelog-extract branch June 1, 2026 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant