Repository navigation
fix(config): rules_engine section defaults enabled to true - #639
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
RulesSection.enablednow defaults totrue(serde default) and is only serialised when false, so arules_engine:section that sets other keys keeps the built-in rule engine on.enabled: falsestill disables it and survives a serialise/deserialise round trip.Why
rules_engine: { max_findings: 0 }(the documented way to raise the cap, #624) silently disabled every built-in rule because the section'senableddefaulted to false and overwrote the default (#638). Seen as a missedsec-hardcoded-secretfinding with a one-key config.Testing
New tests: section with only
max_findingskeeps rules on;enabled: falsedisables and round-trips. fmt, clippy -D warnings, full suite 2x green (1148). Binary: withrules_engine: {max_findings: 0}the builtin rule flagspassword = "abc" + "defgh12345"; withenabled: falseit does not.Closes #638
🤖 Generated with Claude Code