Repository navigation
refactor(review): split deterministic analysis from the LLM call - #577
Merged
Merged
Conversation
Extract engine::deterministic::run (rules, secrets, security, index scans, claim flags) returning a structured DeterministicReport with context() and merge_into(), testable without an LLM. The three index scanners share one scan_changed_files preamble. All ignore/skip/include/exclude matching now goes through engine::path_match (index, review scanners, scan, watch). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: ajianaz <ajianaz@users.noreply.github.com>
This was referenced Oct 8, 2026
ajianaz
added a commit
that referenced
this pull request
Oct 8, 2026
) Covers security hardening (#563, #572, #573), fixes (#553, #561, #562, #564, #565, #574-#576), and the ignore-pattern semantic changes from #577 that can alter which files existing configs exclude. Signed-off-by: ajianaz <ajianaz@users.noreply.github.com> Co-authored-by: ajianaz <ajianaz@users.noreply.github.com> Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Extract the deterministic half of
review_diff_innerintoengine::deterministic, give the three index scanners one shared preamble, and route every ignore/skip/include/exclude match through one matcher (engine::path_match).Why
Closes #569
How
deterministic::run(chunks, config, bridge) -> DeterministicReport(rules, secrets, security, index unused/dead/breaking, claim flags) withcontext(static)andmerge_into(issues). review.rs keeps the LLM call and post-filters. Family order, context text and merge order are unchanged.index_scanner::scan_changed_files: shared preamble (index handle, deleted/skip/additions/dedupe selection, max cap); only the per-file query differs.path_match::PathMatcher: used by index walk, review scanners,cora scaninclude/exclude andcora watch --filter. Semantics are documented in the module. Intentional differences from the retired hand-rolled matcher:**/*.test.tsno longer matchesfootest.ts,vite.config.*no longer matchesvite.configx,src/*.rsnow matches. Slash-free scan/watch patterns now also match by basename.Testing
cargo test --features tree-sitterpassescargo fmt --all -- --checkpassescargo clippy --all-targets --features tree-sitter -- -D warningspassescargo build --release --features tree-sitterpassesRelated Issues
Closes #569
🤖 Generated with Claude Code