chore(deps): pin rustls 0.23.45 (RUSTSEC-2026-0285) + drop deprecated f32 import - #561
Merged
Merged
Conversation
…r tests Two develop-wide red gates, one unblock PR (both verified against CI): - RUSTSEC-2026-0285: rustls 0.23.42 in Cargo.lock trips rustsec audit-check on every open PR. Pin 0.23.45 (same remediation as gaira 2026-10-03); rustls-webpki rides along to 0.103.15. Closes #560. - 'use std::f32;' in the vector tests module resolves f32::EPSILON to the deprecated module-path constant: clippy -D warnings is red on rustc 1.99, now including CI's stable toolchain. Removing the import restores the associated-constant resolution. Closes #557. Lockfile + one test-only line; no runtime code paths touched.
This was referenced Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two develop-wide red gates in one unblock PR (lockfile + one test-only line, no runtime code):
rustls0.23.42 → 0.23.45: RUSTSEC-2026-0285 (TLS 1.3 handshake messages may be sent in plaintext) tripsrustsec/audit-checkon develop and every open PR. Same remediation as gaira (2026-10-03);rustls-webpkirides along to 0.103.15.use std::f32;from thesrc/index/vector.rstests module: it resolvesf32::EPSILONto the deprecated module-path constant — hard clippy error under-D warningson rustc 1.99, now including CI's floating stable toolchain (PR fix(review): report chunked findings when chunks return empty summaries #559's Clippy job failed on exactly this).Why
Every open PR is red on Security Audit; every commit from a rustc ≥1.99 machine was blocked at pre-commit. Fixing both on develop first lets the feature PRs (#559) land on a green base instead of stacking dead check-runs. Closes #560, closes #557.
Testing
cargo test --bin cora index::vector→ 14 passed, 0 failedcargo clippy --all-targets -- -D warnings→ clean locally on rustc 1.99 (was 4 errors)