Repository navigation
ci: add --branch=main to pages deploy for production promotion - #472
Merged
Merged
Conversation
Without explicit --branch=main, wrangler may detect the triggering branch (develop via workflow_dispatch) and deploy as non-production. This matches the pattern used in the website repo deploy workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add explicit
--branch=mainflag to the Cloudflare Pages deploy command indeploy-website.yml.Why
Without
--branch=main, wrangler detects the triggering branch context. When deploy runs viaworkflow_dispatchfromdevelop, wrangler deploys as a non-production deployment — the new build never reaches the production alias (codecora.dev).This matches the pattern already used in the
websiterepo deploy workflow which explicitly passes--branch=main.Testing
codecoradev/website/.github/workflows/deploy-website.yml