Repository navigation
Conversation
Sync main ← develop
Sync main ← develop (theme pin fix)
sync: develop → main for v0.8.2 release
sync: develop to main for v0.8.3 release
…Too Large) - Add `exclude` field to [package] for vendored/, docs/, .github/, tests/ - Gate `token_vocab` module behind `pretrained-embed` feature flag - Package size: 31.9MB → 300KB (well under 10MB crates.io limit) - Pretrained embeddings still work locally via `--features pretrained-embed`
fix: exclude vendored embeddings from crates.io package
Old: cora-{os}-{arch} (bare binary)
New: cora-{target}-v{version}.{ext} (tarball/zip)
- Map to Rust target triples (e.g. aarch64-apple-darwin)
- Extract tar.gz / zip before install
- Add Windows MSYS2/MINGW detection
- Add db_writer module with save_review_to_db() that writes to reviews, findings, and finding_events tables (Schema v5) - Wire db_writer::save_review_to_db into execute_review (both single-file and chunked paths) and execute_scan - Rename graph.db references to cora.db in data_dir.rs - Add Schema v5 migration: reviews, findings, finding_events tables with indexes on fingerprint, file_path, review_id - All DB writes are best-effort (non-fatal) to never block a review - 742 tests pass, 0 warnings
- Add resolve_stale_findings() to db_writer: queries open findings in the same project, compares fingerprints against current review, and marks missing ones as 'resolved' with 'auto_resolved' event - Expose compute_fingerprint_pub() so callers can compute fingerprints for the current issue set before calling resolve_stale_findings - Wire auto-resolve into both review paths (single-file + chunked) and scan, called immediately after save_review_to_db - Fix duplicate #[cfg(test)] attribute in db_writer tests - 742 tests pass, 0 warnings
Subcommands: - list: show findings (open by default, --all for all, --severity/--file filters, --json) - stats: summary counts (total, open, resolved, dismissed, resolution rate) with --json - dismiss <id>: mark finding as dismissed with optional --reason - reopen <id>: reopen a dismissed/resolved finding Read-only actions (list, stats) use open_db_for_read() — no migrations. Write actions (dismiss, reopen) use open_db_for_write() — runs migrations. End-to-end verified: dismiss → list --all → reopen → stats --json all working against real cora.db. 742 tests pass, 0 warnings.
Collaborator
Author
|
Closing: branch is stale (based on pre-Phase1 develop) and CI fails (Format + Clippy). Content is still relevant — will rebase onto latest develop and reopen as fresh PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issues: #397, #398, #399, #400 + installer URL fix
What Changed
cora findingsCLI —list,stats,dismiss,reopensubcommandsTest Results
cora indexcora scancora braincora findingsend-to-end: dismiss → list --all → reopen → stats --json all workingKnown Issues (non-blocking)
scan --format json— progress/warn logs leak to stdout (should be stderr).cora.yamlhas unknown fieldseverity— needs updateBinary
cora 0.8.4— 11MB release build