Repository navigation
fix: profiles bugs — path resolution, fail-fast, dedup merge (#238) - #239
Merged
Merged
Conversation
Fixes 3 Code Scanning alerts: - Alert #69: resolve profile file paths relative to project root, not CWD. New resolve_profile_with_root() accepts optional root. - Alert #72: fail fast on invalid profile config instead of warn-only. merge_into() now returns Result<(), CoraError>. - Alert #73: merge focus_areas by id (replace existing, append new) instead of blind extend() that caused duplicates. Default behavior preserved: no profile = normal review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 3 Code Scanning alerts from cora self-review.
resolve_profile_with_root()accepts optional project rootmerge_into()now returnsResult, fails fast.extend()appended focus_areas without dedupid: replace existing, append newDefault behavior unchanged: no profile = review runs normally.
419 tests pass, clippy clean.