Repository navigation
feat(review): integrate auto-chunker into review command - #236
Merged
Merged
Conversation
- Add --no-auto-chunk flag (auto-chunk enabled by default for large diffs) - Add execute_chunked_review() that splits diffs via chunker::chunk_diff() - Review each chunk independently with full pipeline (cache, stream, rules) - Merge findings and deduplicate by (file, line, title) tuple - Accumulate token usage across chunks for accurate reporting - Graceful partial results on chunk failure (warns, continues) - Progress events emitted per chunk when --progress is set - Quality gate evaluated on merged results - Fix pre-existing borrow lifetime issues in chunker tests - Register chunker module in engine/mod.rs Closes #228
…ailure - Propagate should_block=true from any chunk to merged response - Return EXIT_BLOCKED when all chunks fail instead of silent pass - Addresses Cora self-review findings on chunked review flow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #228
Integrates the existing chunker module (
src/engine/chunker.rs) into the review command so that large diffs exceedingmax_diff_sizeare automatically split and reviewed in pieces.Changes
max_diff_sizeare automatically split. Use--no-auto-chunkto disable and hard-fail instead.execute_chunked_review()inreview.rs:chunker::chunk_diff()EXIT_BLOCKEDwhen ALL chunks fail (no silent pass)should_blockfrom any chunk to merged response--progressis setchunker.rstestschunkermodule inengine/mod.rs--no-auto-chunkChecklist
cora reviewCLI (as--no-auto-chunk, default on)execute_review()when diff > max_diff_sizeTest Results