Skip to content

fix: skip SARIF upload when no findings #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajianaz merged 1 commit into from
Jun 3, 2026
Merged

fix: skip SARIF upload when no findings #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion .github/actions/cora-review-simple/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,29 @@
> cora-results.sarif 2>/dev/null
echo "Cora review complete ($(wc -c < cora-results.sarif) bytes)"

- name: Upload SARIF to GitHub Code Scanning
- name: Check SARIF for findings
id: sarif-check
if: inputs.upload-sarif == 'true'
shell: bash
run: |
RESULTS=$(python3 -c "
import json, sys
try:
data = json.load(open('cora-results.sarif'))
results = data.get('runs', [{}])[0].get('results', [])
print(len(results))
except:
print(0)
" 2>/dev/null || echo "0")
echo "results=$RESULTS" >> "$GITHUB_OUTPUT"
if [ "$RESULTS" -gt 0 ]; then
echo "SARIF contains $RESULTS finding(s) — will upload."
else
echo "SARIF has no findings — skipping upload."
fi

- name: Upload SARIF to GitHub Code Scanning
if: inputs.upload-sarif == 'true' && steps.sarif-check.outputs.results > 0
continue-on-error: true
uses: github/codeql-action/upload-sarif@v4
with:
Expand Down
23 changes: 22 additions & 1 deletion .github/actions/cora-review/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,29 @@
exit 1
fi

- name: Upload SARIF to GitHub Code Scanning
- name: Check SARIF for findings
id: sarif-check
if: inputs.upload-sarif == 'true'
shell: bash
run: |
RESULTS=$(python3 -c "
import json, sys
try:
data = json.load(open('cora-results.sarif'))
results = data.get('runs', [{}])[0].get('results', [])
print(len(results))
except:
print(0)
" 2>/dev/null || echo "0")
echo "results=$RESULTS" >> "$GITHUB_OUTPUT"
if [ "$RESULTS" -gt 0 ]; then
echo "SARIF contains $RESULTS finding(s) — will upload."
else
echo "SARIF has no findings — skipping upload."
fi

- name: Upload SARIF to GitHub Code Scanning
if: inputs.upload-sarif == 'true' && steps.sarif-check.outputs.results > 0
continue-on-error: true
uses: github/codeql-action/upload-sarif@f52b05f4acaaa234e44466e66d29050e135ea9ef # v4.36.0
with:
Expand Down
Loading