Skip to content

chore(ci): bump actions & add Node 24 readiness - #142

Merged
ajianaz merged 2 commits into
developfrom
chore/ci-action-updates
Jun 2, 2026
Merged

ajianaz merged 2 commits into
developfrom
chore/ci-action-updates

Conversation

@ajianaz

@ajianaz ajianaz commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

Sync CI action versions with uteke (latest):

Change Before After
actions/upload-artifact @v4 @v7
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 missing true (ci.yml + release.yml)
cora-review fallback version v0.1.7 v0.2.0

Why: GitHub will force Node.js 24 migration by June 16, 2026. upload-artifact@v4 is deprecated and incompatible with Node 24.

⚠️ Cora flagged upload-artifact@v7 as "does not exist" — this is a false positive (LLM knowledge cutoff). Latest release is v7.0.1.

Note: Infisical OIDC adoption is deferred — needs Infisical trust relationship setup for codecoradev/cora-cli org first.

Co-Authored-By: codecoradev noreply@github.com

- upload-artifact@v4 → @v7 (latest, Node 24 compatible)
- Add FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true to ci.yml & release.yml
- Update cora-review fallback version v0.1.7 → v0.2.0

Co-Authored-By: codecoradev <noreply@github.com>
@github-actions

github-actions Bot commented Jun 2, 2026 •

Copy link
Copy Markdown

🔍 Cora AI Code Review

❌ Blocked — critical issues found.

🔴 Error (1)

  • .github/workflows/release.yml:82 — As of this review, actions/upload-artifact latest major version is v4. Pinning to @v7 will cause the workflow to fail at runtime because that version tag does not exist. This looks like an accidental version bump.

Review powered by cora-cli · BYOK · MIT

Previously || true swallowed all cora exit codes, so LLM API failures
(504, timeout, auth error) resulted in empty SARIF but job SUCCESS.

Now: capture exit code, fail job if cora exits non-zero AND SARIF is
empty (< 10 bytes = no valid results). Partial results still pass.

Co-Authored-By: codecoradev <noreply@github.com>
@ajianaz
ajianaz merged commit d83964d into develop Jun 2, 2026
7 of 8 checks passed
@ajianaz
ajianaz deleted the chore/ci-action-updates branch June 2, 2026 15:10
@ajianaz ajianaz mentioned this pull request Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant