Repository navigation
fix(app): a request whose element is gone no longer holds up every form - #175
Merged
Merged
Conversation
In the desktop app "Koppel met Claude" did nothing, nor did any other form, until the window closed. A part that fetches itself sent an htmx request, and a page change replaced that part before the answer came. htmx reports the end only to the element that sent it, so app.js kept the request in its list and every POST form waited for it. The request's own loadend now counts too. Playbook: n.v.t. — a fix in Huismus's own app.js, no workflow change Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In de desktop-app deed Koppel met Claude niets, en daarna ook geen ander formulier, tot het venster dichtging.
Oorzaak: een deel dat zichzelf ververst stuurde een htmx-verzoek; een paginawissel verving dat deel voordat het antwoord kwam. htmx meldt het einde alleen aan het element zelf, dus
app.jsbleef het verzoek als lopend zien, en elk POST-formulier wachtte erop.Fix:
app.jstelt nu ook het einde van het verzoek zelf (loadend), naasthtmx:afterRequest.test_a_request_whose_element_is_gone_does_not_hold_up_the_forms(ook groen in WebKit)BUGS-BY-HAND.md./scripts/verify.shgroen🤖 Generated with Claude Code