feat(benchmark): add tests for --disable-rate-limiter flag#34
Open
thanhle74 wants to merge 1 commit into
Open
Conversation
- Add 16 unit tests for calculate_worker_rps and interval_for_worker_rps - Test rate limiter bypass returns infinity (no pacing) - Test normal mode divides RPS by concurrency - Test error handling for invalid concurrency and RPS values - Test cross-platform deterministic behavior - All 16 tests pass Bounty: codeboost-tr/zeroeye #4 ($20)
|
😅 Ups... the issue does not have any reward yet! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive unit tests for the
--disable-rate-limiterflag intools/benchmark.py. The flag already exists in the CLI parser but lacked test coverage.Changes
tests/test_benchmark_rate_limiter.pywith 16 tests covering:calculate_worker_rps()— normal mode, bypass mode, error casesinterval_for_worker_rps()— finite/infinite RPS, error casesbuild-e496f08f.json,build-e496f08f.logd)Testing
Checklist
/claim #4