-
Notifications
You must be signed in to change notification settings - Fork 0
V0.4.1/git squash fix #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -19,6 +19,7 @@ | |||||||||||||||||||||||||||
| "expected_output": "A polished grouped summary that keeps important technical identifiers intact and uses the shared git-visual wording style.", | ||||||||||||||||||||||||||||
| "expectations": [ | ||||||||||||||||||||||||||||
| "Preserves technical identifiers exactly where possible", | ||||||||||||||||||||||||||||
| "Starts descriptions lowercase after the emoji unless a leading technical identifier requires original casing", | ||||||||||||||||||||||||||||
| "Uses the same emoji-first language as git-visual-commits and defaults to no prefix unless explicitly requested", | ||||||||||||||||||||||||||||
| "Reads like a curated human-written condensed history rather than a dump of commit subjects", | ||||||||||||||||||||||||||||
| "Keeps distinct meaningful efforts on separate lines", | ||||||||||||||||||||||||||||
|
|
@@ -101,6 +102,7 @@ | |||||||||||||||||||||||||||
| "expected_output": "A grouped squash summary that uses emoji-first, prefixless lines by default and only switches to prefixed lines when the user explicitly requests that combo.", | ||||||||||||||||||||||||||||
| "expectations": [ | ||||||||||||||||||||||||||||
| "Defaults to emoji plus description lines without adding conventional prefixes", | ||||||||||||||||||||||||||||
| "Starts each prefixless description lowercase after the emoji", | ||||||||||||||||||||||||||||
| "Uses the shared commit-language reference as the source of truth for that prefixless default", | ||||||||||||||||||||||||||||
| "Keeps the output in grouped summary line form rather than explaining the rule at length" | ||||||||||||||||||||||||||||
| ] | ||||||||||||||||||||||||||||
|
|
@@ -126,6 +128,17 @@ | |||||||||||||||||||||||||||
| "Keeps the build-system or refactor effort on its own retained line when the diff shows a separate intent", | ||||||||||||||||||||||||||||
| "Returns grouped summary lines only" | ||||||||||||||||||||||||||||
| ] | ||||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||
| "id": 12, | ||||||||||||||||||||||||||||
| "prompt": "Draft the normal git-visual squash summary for this branch. Make it paste-ready for GitHub, keep identifiers like ValidateSkillTemplates intact, and keep the repo's emoji-first style.", | ||||||||||||||||||||||||||||
| "expected_output": "A paste-ready grouped squash summary whose normal descriptions start lowercase after the emoji while still preserving case-sensitive technical identifiers when they appear.", | ||||||||||||||||||||||||||||
| "expectations": [ | ||||||||||||||||||||||||||||
| "Starts normal description text lowercase after each emoji", | ||||||||||||||||||||||||||||
| "Preserves case-sensitive technical identifiers such as ValidateSkillTemplates exactly", | ||||||||||||||||||||||||||||
| "Does not add conventional prefixes unless explicitly requested", | ||||||||||||||||||||||||||||
| "Returns grouped summary lines only without explaining the casing rule" | ||||||||||||||||||||||||||||
| ] | ||||||||||||||||||||||||||||
|
Comment on lines
+136
to
+141
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: skills/git-visual-squash-summary/evals/evals.json
Line: 136-141
Comment:
**New eval 12 missing explicit expectation for the identifier-first exception**
The `expected_output` prose for eval 12 correctly describes the exception ("preserving case-sensitive technical identifiers when they appear"), but none of the four expectations in the array covers the inverse case — that a line starting with `ValidateSkillTemplates` should *not* be forced to lowercase. Evals 2 and 9 include this explicit guard; without it in eval 12, the grader can pass a model that lowercases all identifiers without penalisation.
```suggestion
"expectations": [
"Starts normal description text lowercase after each emoji",
"Does not lowercase leading technical identifiers that require original casing",
"Preserves case-sensitive technical identifiers such as ValidateSkillTemplates exactly",
"Does not add conventional prefixes unless explicitly requested",
"Returns grouped summary lines only without explaining the casing rule"
]
```
How can I resolve this? If you propose a fix, please make it concise. |
||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||
| ] | ||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Fixed entry states guidance was "Standardized ... across SKILL.md,
references/commit-language.md, and eval contracts," butreferences/commit-language.mddoes not appear anywhere in this PR's diff. Changelog readers will expect that file to have been modified. The file's examples were already lowercase-compliant before this PR, so either the entry should be rephrased to reflect verification (not standardization), or the file should have been explicitly updated with the new casing guidance text.Prompt To Fix With AI