Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/pt_snap_cli/query/templates/business/leak_detection.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,6 @@ queries:
default: 0
required: false
description: Minimum leak size in bytes
device_id:
type: int
default: null
required: false
description: Device ID to query
query: |
SELECT id, address, size, allocEventId
FROM {{ device_block_table }}
Expand Down
10 changes: 10 additions & 0 deletions tests/query/test_registry.py
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,16 @@ def test_list_by_category_business(self):
assert "test_biz" in result
assert "leak_detection" in result

def test_leak_detection_template_exposes_only_min_size(self):
"""Regression for issue #90: ``leak_detection`` must not advertise
``device_id`` as a parameter because device selection is owned by the
top-level ``--device`` flag, Python ``device_id`` argument, and focus.
"""
info = get_template_info("leak_detection")
assert info is not None
assert "min_size" in info["parameters"]
assert "device_id" not in info["parameters"]

def test_list_by_category_with_details(self):
register_query(
QueryTemplate(
Expand Down
26 changes: 26 additions & 0 deletions tests/test_contract_cli_mcp.py
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,32 @@ def test_template_info_contract_matches_cli_and_mcp_semantics(
assert cli_info == mcp_info


def test_leak_detection_template_does_not_advertise_device_id(
contract_db: Path, mcp_server: ModuleType
) -> None:
"""Regression for issue #90: ``device_id`` is resolved from focus / --device,
not from template parameters, so the template metadata must not expose it.
"""
cli_result = runner.invoke(
app,
["query", str(contract_db), "--template-info", "leak_detection"],
)
assert cli_result.exit_code == 0

server = _set_mcp_focus(mcp_server, contract_db)
cli_info = _normalize_cli_template_info(cli_result.stdout)
mcp_info = server.get_template_info("leak_detection")

for info in (cli_info, mcp_info):
assert info is not None
assert "parameters" in info
assert "device_id" not in info["parameters"], (
"leak_detection must not advertise device_id; use --device / "
"API device_id / focus selection instead."
)
assert "min_size" in info["parameters"]


def test_query_execution_contract_matches_cli_and_mcp_semantics(
contract_db: Path, mcp_server: ModuleType
) -> None:
Expand Down
Loading