Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from ....util.sqlite_meta import SqliteColumn, SqliteTable, SqliteDB
from .defs import EventFieldDefs, BlockFieldDefs
from ....util.sqlite_meta import SqliteColumn, SqliteDB, SqliteTable
from .defs import BlockFieldDefs, EventFieldDefs

TRACE_ENTRY_ACTION_VALUE_MAP = {
"segment_map": 0,
Expand Down Expand Up @@ -70,6 +70,13 @@ def create_trace_entry_table(self, device: int = 0):
),
delete_if_exists=True,
)
table = self.get_trace_entry_table(device)
for column in (
EventFieldDefs.ALLOCATED,
EventFieldDefs.ACTIVE,
EventFieldDefs.RESERVED,
):
table.create_index(self.conn, column)

def create_block_table(self, device: int = 0):
self.create_table(
Expand All @@ -78,6 +85,13 @@ def create_block_table(self, device: int = 0):
),
delete_if_exists=True,
)
table = self.get_block_table(device)
for column in (
BlockFieldDefs.ALLOC_EVENT_ID,
BlockFieldDefs.FREE_EVENT_ID,
BlockFieldDefs.SIZE,
):
table.create_index(self.conn, column)

def get_trace_entry_table(self, device: int = 0):
return self.get_table_by_name(self.get_trace_table_name_by_device(device))
Expand Down
37 changes: 37 additions & 0 deletions tests/test_snapshot_db.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,15 @@ def _pragma(conn: sqlite3.Connection, name: str) -> object:
return conn.execute(f"PRAGMA {name}").fetchone()[0]


def _indexed_columns(conn: sqlite3.Connection, table: str) -> set[str]:
indexes = conn.execute(f"PRAGMA index_list('{table}')").fetchall()
return {
column[2]
for index in indexes
for column in conn.execute(f"PRAGMA index_info('{index[1]}')").fetchall()
}


def test_snapshot_db_optimizes_import_writes(tmp_path: Path) -> None:
db = SnapshotDb(str(tmp_path / "snapshot.db"))
try:
Expand All @@ -30,3 +39,31 @@ def test_generic_sqlite_db_keeps_default_write_settings(tmp_path: Path) -> None:
finally:
db.conn.close()
baseline.close()


def test_create_trace_entry_table_adds_query_indexes(tmp_path: Path) -> None:
db = SnapshotDb(str(tmp_path / "snapshot.db"))
try:
db.create_trace_entry_table(device=2)

assert _indexed_columns(db.conn, "trace_entry_2") == {
"allocated",
"active",
"reserved",
}
finally:
db.conn.close()


def test_create_block_table_adds_query_indexes(tmp_path: Path) -> None:
db = SnapshotDb(str(tmp_path / "snapshot.db"))
try:
db.create_block_table(device=2)

assert _indexed_columns(db.conn, "block_2") == {
"allocEventId",
"freeEventId",
"size",
}
finally:
db.conn.close()
Loading