Skip to content

Add basedPyright check to CI workflow - #60

Merged
codeasier merged 2 commits into
mainfrom
feat/add-basedpyright-ci-check
Apr 22, 2026
Merged

codeasier merged 2 commits into
mainfrom
feat/add-basedpyright-ci-check

Conversation

@codeasier

Copy link
Copy Markdown
Owner

📝 Description

Add a basedPyright check to the existing test workflow, add the dev dependency, and include minimal project configuration so the same command passes locally and in CI.

🔗 Related Issue

Fixes #58

🧪 Testing

  • Tests added/updated
  • Manual testing completed

Manual verification run locally:

  • python -m pytest tests — 267 passed
  • python -m basedpyright --pythonpath "$(python -c 'import sys; print(sys.executable)')" — 0 errors, 0 warnings

✅ Checklist

  • Code follows project guidelines
  • Documentation updated (if applicable)
  • No new warnings introduced
  • Changes tested locally

📸 Screenshots (if applicable)

N/A

📋 Additional Notes

The workflow runs basedPyright with the active interpreter path explicitly to avoid environment-resolution mismatches that caused typer import errors during local verification.

codeasier added 2 commits April 22, 2026 00:23
Run basedpyright in CI with the active Python interpreter and add the minimal project config needed to keep local and CI checks aligned.

@codeasier codeasier left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codeasier
codeasier merged commit 555f7c1 into main Apr 22, 2026
5 checks passed
@codeasier
codeasier deleted the feat/add-basedpyright-ci-check branch April 22, 2026 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add basedPyright check to CI workflow

1 participant