Repository navigation
test: enforce dataset route scale and subprocess failure contracts - #259
Conversation
|
Latest-head CI verification (2026-10-11): commit |
检视结论:approve对照 #252 路由/预算/深 offset:CLI 子进程错误契约;百万 lifecycle ATTACH≡scratch;深 offset + 预算优先级;3 个 million 节点进 nightly。failure + runner 定向通过。SIGKILL 清理留给 #261 文档化,可接受。 合入注意:与 #260 / #263 在 |
Rebase reviewed PR259 onto current main after PR260. Union two wheel gates with all three route-million gates and preserve every fail-closed runner test. Refs #252.
d279ee2 to
5982e43
Compare
|
按检视要求,在 #260 后将本 PR 的唯一增量提交 rebase 到实际 main 仅两处 runner 冲突:REQUIRED 并集为 2 个 wheel 节点 + 3 个 route-million 节点,共 5 个;negative tests 完整并集,short-final boundary 保留。生产代码、双语文档、四分片平台工作流和独立 200-seed step 不变,三个新增 route/failure 文件与原审阅提交字节相同。 实际 main 基树和最终完整树均与已独立审阅验证的本地 preview 一致。该 preview 源 |
Summary
Adds the bounded route, deep-pagination and error-contract acceptance coverage from #252.
REQUIRED_TEST_NODES, alongside the existing installed-wheel case. Add per-node missing/wrong-file/skip/failure/error rejection tests. Ordinary PR CI keeps the nine focused cases; the million-scale cases are mandatory nightly/manual gates.Dependency and scope
Based on #255's nightly infrastructure at
68d89670b188c93e41b1a5d8f41903057e5ada06, verified tree-equivalent to localfe86fcff7b695c9aa05e86bc87dc15d888dee4fa.The reviewed #252 test implementations at
2a3113839709ac386d76ee73145722e09b65bd42are unchanged. The integration only adds required-node wiring and its tests. No runtime behavior or budget defaults change.This is partial coverage for #252. SIGKILL/SIGTERM cleanup and concurrency/concurrent-rewrite behavior remain for separate disposition. This PR makes no signal-cleanup completion claim. The installed-wheel baseline remains the existing 500,002-event test; the million-lifecycle route tests are synthetic SQLite acceptance. Clean-wheel expansion is handled separately in #250.
Validation
git diff --checkpassed.b1fec8626996c03f0ae275a55dbe980655e08502. The summary records all four complete required node IDs and binds that source SHA to the supplied wheel SHA-256. This includes the existing installed-wheel baseline and all three million-lifecycle gates.76e95ddaea92e003fa7065c552ddaf748de4eb527098f6443c795c90e3f8dbcb.Snapshot runtime provenance
Snapshot provenance decision: no-update
Snapshot provenance no-update reason: This change adds tests and CI required-node wiring only; no files under src/pt_snap_cli/snapshot/ change.
Independent review approved the unchanged test implementations: 9 new focused cases and 186 existing regressions passed (2 intentional skips). Root reviewed the required-node integration. The final local generic nightly runner completed 4 passed, zero skips/failures/errors in 144.57s, with all four exact required identities and matching source/wheel evidence. Remote CI/manual nightly execution remains pending. This branch includes #255's infrastructure commits; review/merge #255 first.