Repository navigation
perf: reuse bounded lifecycle reduction for larger scopes - #245
Merged
Merged
Conversation
Closed
Owner
Author
检视结论:approve对照 #237:小范围保留 ATTACH;观察数探测超阈值后走 scratch 一次归约;summary 冲突 / coverage 保留;scratch=0 禁用、失败硬失败不回退——均符合约定。 已核实
作者提到的 1M×~4 片对比未在本机重跑(产物未复用),小规模方向与机制一致。本评论不 approve/merge。 |
codeasier
marked this pull request as ready for review
October 11, 2026 05:38
codeasier
added a commit
that referenced
this pull request
Oct 11, 2026
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
范围
Refs #237。保留小范围 ATTACH;较大观察范围复用一次有界 scratch 归约,让 summary/page/buckets 不再重复完整 UNION/proof/GROUP BY/ROW_NUMBER。
验证
基线 main
ffa71df0ddf0fb5f17a904f4092898a27287d21e,审核tree3cbc4142b6c61f0cf5dd853454d69b74fc96eb57。同一合成产物:1M lifecycles / 2.5M observations / 3 shards(来源113,692,672 bytes)。
百万规模值为单次受控环境观测,不作一般提速保证;另有120k重复基准和单片4096/4097边界(1 warmup +3 repetitions)。自动/强制scratch结果及完整coverage相同,每次只有一次构建,derived64,389,120B,源hash不变且scratch清空。微小输入ATTACH更快,故未一律切换。可复用同产物benchmark随PR提交。
保留草稿,不自动合并。