Skip to content

feat: expose immutable query limits across API and CLI - #244

Merged
codeasier merged 2 commits into
mainfrom
feat/239-public-query-limits
Oct 11, 2026
Merged

codeasier merged 2 commits into
mainfrom
feat/239-public-query-limits

Conversation

@codeasier

Copy link
Copy Markdown
Owner

范围

Refs #239 的公共预算配置部分;ID 深分页在独立 PR,不关闭整个 issue。

新增 immutable QueryLimits,统一 API/QueryService/SnapshotAnalyzer/ReportService 与 query/report CLI。按字段 explicit > environment > default,公开有效限额及错误信息。配置与可变计数分离:独立调用重建计数,组合 report 共享累计预算/deadline。

默认仍为 100,000 rows、64 MiB work bytes、512 MiB scratch pages;rows/bytes 仅正整数,不引入无限值。scratch=0 禁用,非零沿用4096 bytes–4 GiB。超限仍硬失败,不返回部分全局结论。提高预算会增加资源风险,双语文档说明。

验证

基线 main ffa71df0ddf0fb5f17a904f4092898a27287d21e;审核 tree 08345549303892c314856dd1ad1d68f111ec7fe3。

  • 最终 focused 122 passed;广泛 query/dataset/lifecycle/governance 707 passed、2 intentional slice-leak skips;adapter 回归296 passed。
  • 120k-event 非ID排序深分页与120k leak全量结果:默认fail、显式提高限额pass,两项容量测试通过(不依赖另一个分页补丁)。
  • 独立审查72 focused passed,覆盖默认不变、strict parsing/优先级、fresh counters/shared report、metadata和领域错误,无阻塞发现。
  • 全库 Ruff/Black/diff check 通过,basedpyright 0 errors(既存 warnings)。

本地全套集成、coverage、精确 wheel 与远端完整 CI 继续验证,未将未执行步骤称通过。保留草稿,不自动合并。

Copy link
Copy Markdown
Owner Author

检视结论:approve

对照 #239:默认仍 100k 行 / 64 MiB / 512 MiB scratch;immutable QueryLimits;explicit > env > default;无无限值;超限硬失败——符合约定。CLI --max-work-* 与 Report 共享累计预算也核对过。

复测:124 passed;defaults 断言 OK;gates OK。本评论不 approve/merge。

@codeasier
codeasier marked this pull request as ready for review October 11, 2026 05:59
@codeasier
codeasier merged commit 1c580da into main Oct 11, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant