Repository navigation
feat: rework standalone ordered frames and memory-tree reports (#206) - #232
Merged
Merged
Conversation
9 tasks done
Owner
Author
|
最终本地验收完成:当前head55325a82757754dbe061654f061d31acb5d409d4、tree4b461866731b8a10caf7f8e1ddf4e4c9601d1bb9。
边界:实际Chromium因环境socket限制未启动,Node DOM执行实际renderer JavaScript并覆盖zoom/reset/search/hover/恶意文本转义,但不构成真实浏览器布局验收。clean-wheel使用既有依赖目录的临时适配,不宣称全新依赖解析。仍为单库功能,native-v2/compat-v1保留,跨片树不在本PR范围;当前远端exact-head CI另行核验。 |
Owner
Author
|
已追加修复提交 真实 fixture 浏览器验收发现,原比例图中小分支可被固定间隙压成零宽,搜索着色也无法进入。现在保留原始面积比例和所有节点数据,新增全树搜索结果、直接子节点列表、父级导航及稳定键盘焦点。同名结果按完整调用路径和 node_id 区分,零字节/微小节点也有可操作入口;文本仍用 textContent。 验证:
本次 CI:https://github.com/codeasier/pt-snap-cli/actions/runs/38101001659 ,Python3.10–3.13、Chromium、Lint、provenance共7个jobs全部成功。本评论补充并更新先前说明中的浏览器验收限制;不宣称移动端/跨浏览器或真实GPU执行已验收。 |
codeasier
marked this pull request as ready for review
October 11, 2026 01:28
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reworks the standalone scope of #206 on top of the tested #230/#231 content, replacing the obsolete implementation in #207. This PR is for review; it does not expand cross-shard frame-tree support.
event_framesreturns original order (or explicit root-first display without changing position), and rejects partial/corrupt arrays by returning no rows.active_memory_frame_tree_at_eventdecomposes live blocks after an event by full caller path. Inclusive/self bytes, requested bytes, and block counts conserve at each node. Pending-free stays included; static, preexisting, captured-empty, and missing/corrupt attribution remain distinct.report memory-treeshares the query/API contract, supports timeout and text/JSON/self-contained HTML, and rejects partial or nonconserving graphs. Dataset roots are explicitly unsupported rather than implicitly selecting a shard.Related work
Implements the single-database foundation requested by #206; supersedes the unmerged approach in #207. Cross-shard trees remain outside scope. No issues/PRs are closed automatically by this description.
Final verification
Tested head:
70f5817a93cad2b36310c1067a814889ba350e0e.Frozen content tree:
71e00c3f529b654ad200d13ca998063cc6d79490.Actual-browser verification and screenshots
Renderer SHA256:
5dca5252bd35cda27ebaf57d058bd2d59745686c485ded6954707838adddc481.Tested in real cloud Chrome on 2026-10-11 01:05:39–01:08:02 UTC, with real mouse and keyboard input. Six pickle-derived pages passed deepest 40-byte frame selection, distinct same-name paths, global search across unrelated focus changes, reset, zero results, clearing search, and focus preservation. Repeated Tab/Enter child navigation was exercised.
Captured filenames/functions were anonymized before testing; topology, numbers and renderer behavior were unchanged. No raw pickle/database, original source path, account information or credentials are published.
Initial proportional flamegraph and root totals
Previously zero-width deepest frame reached through search: inclusive/self/requested are all 40 bytes
Keyboard navigation: visible blue focus outline on the next child-list button
Evidence provenance and scope
Scope and limitations
This is the standalone single-database feature; cross-shard frame trees remain outside scope. Actual-fixture browser acceptance does not claim mobile/other-browser/GPU coverage, Space-key activation, every individual tiny node or every synthetic edge case. Dedicated automated Chromium tests cover the synthetic edge cases separately. The temporary interactive preview was restored to owner-only; these three approved anonymized screenshots remain available as PR evidence.
Snapshot provenance decision: updated