Repository navigation
fix: close test coverage gaps for mapper and executor - #23
Merged
Merged
Conversation
Add missing test cases: - mapper: KeyError for unregistered model factory, bool string conversion, conversion error fallback - executor: execute_on_all_devices happy path, template not found, empty device list Closes #17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Add missing test coverage:
Mapper (4 new tests):
map_to_modelraisesKeyErrorfor unregistered factory (with message check)map_all_to_modelpropagatesKeyError"true","false","1","0")Executor (3 new tests):
execute_on_all_deviceshappy path with multiple devicesexecute_on_all_devicesraises for missing templateexecute_on_all_devicesreturns empty dict with no devices🔗 Related Issue
Fixes #17
🧪 Testing
✅ Checklist