Repository navigation
fix: reuse budgeted dataset event sources (#222) #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c5ed2a8
fix: narrow dataset trace projections by template (#220)
codeasier b1a2d06
fix: reuse budgeted event sources within dataset queries (#222)
codeasier eda4916
fix: defer event page hydration and reuse frame schema checks
codeasier 9738430
fix: preserve dataset source cache validation contracts
codeasier 2ad2976
merge: reconcile equivalent squash ancestry without source changes
codeasier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Low]
events_from_rows把每个扫描行写入self._events,并保留到整个操作结束。旧的_stacks每批结果处理后即释放。预算上限是序列化字节(注释也说明不是 RSS 上限),Python 对象开销会使实际内存高于计费字节。去除双读的取舍是合理的,但建议在注释中说明,或在多分片 v1 数据集上测一下峰值内存。There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已更新至
973843032d61a999ec9d00b544f8bb89d1ff49e5。已在 events_from_rows 文档中明确:源对象保留到当前 resolver 操作结束,序列化值预算不包含 Python 对象开销,也不是 RSS 上限。本次未将其表述为峰值内存保证。
验证:相关回归 54/54、provenance 7/7,Ruff/Black/diff 与 type check(0 errors)通过。最终完整套件 1950/1950,wheel 构建/审计/安装验收通过。远端提交与 CI 另行补充。