Skip to content

feat(dataset): define sharded SnapshotDB compatibility contract (#198) - #209

Closed
codeasier wants to merge 2 commits into
mainfrom
fix/issue-198-09244150
Closed

codeasier wants to merge 2 commits into
mainfrom
fix/issue-198-09244150

Conversation

@codeasier

Copy link
Copy Markdown
Owner

📝 Description

First PR of the #198–#205 dependency stack, based on main.

Commits in this PR:

7 files changed, 1265 insertions(+):

README.md
README_zh.md
docs/README.md
docs/en/sharded-snapshotdb.md
docs/zh/sharded-snapshotdb.md
src/pt_snap_cli/core/dataset_contract.py
tests/test_dataset_contract.py

🔗 Related Issue

Refs #198 — deliberately no auto-closing keywords; the issue stays open because GUI/C++/installed-wheel acceptance is human-deferred.

Review comment: #198 (comment)

🧪 Testing

  • Tests added/updated
  • Manual testing completed

Manually verified the bilingual guides, the immutable upstream blob links and the docs governance rules; no runtime behavior is claimed beyond the contract tests.

  • Owning focused run: 132 passed.
  • Owning full suite at the delivered head: 1540 passed; coverage with branches enabled 91.85% (the project's combined line+branch metric).
  • Ruff and Black passed; basedpyright 0 errors (815 informational warnings).
  • Staged governance: 27 passed after the corrective commit.
  • Independent parent verification on the delivered head: fixture provenance + dataset contract, 105 passed.

✅ Checklist

  • Code follows project guidelines
  • Documentation updated (if applicable)
  • No new warnings introduced
  • Changes tested locally

"No new warnings" keeps the pre-existing external pytest-asyncio startup deprecation and existing informational type warnings unchanged rather than hidden; ResourceWarning / PytestUnraisableExceptionWarning remain errors.

Snapshot Runtime Provenance

  • Snapshot provenance evaluation completed when snapshot runtime files change
    No snapshot runtime files change in this PR, so no provenance declaration is required.

📸 Screenshots (if applicable)

Not applicable — no user-interface or C++ changes in this PR.

📋 Additional Notes

  • CI: this PR targets main, so the Test workflow (snapshot provenance, lint, Python 3.10–3.13 matrix with coverage floors, 3.13 wheel build/audit/clean-wheel acceptance) runs for head 9e17e73.

Head SHA: 9e17e734a205eb2658f97475353379e2f7af4a02; branch fix/issue-198-09244150. All checks above were recorded locally on this exact head; the C++/GUI consumer and installed-wheel profile remain untested and unclaimed.

@codeasier

Copy link
Copy Markdown
Owner Author

Superseded by #216 — the complete #198–#205 chain (including this PR’s commits) was merged into main via #216 (rebase merge) after retargeting. This PR stays as the per-issue review record; the linked issue remains open pending the human-deferred GUI acceptance.

@codeasier codeasier closed this Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant