Repository navigation
Conversation
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
First PR of the #198–#205 dependency stack, based on
main.sharded-snapshotdbguides and cross-links from both READMEs.101f65b877a267ffd5f66ea3834706057ba243e5, preserving license and attribution evidence within the branding contract.Commits in this PR:
9e17e73fix(docs): preserve dataset source evidence within branding contract ([FEATURE] 定义分片 SnapshotDB 产物协议与 msinsight 兼容契约 #198)67e26f4feat(dataset): define sharded SnapshotDB compatibility contract ([FEATURE] 定义分片 SnapshotDB 产物协议与 msinsight 兼容契约 #198)7 files changed, 1265 insertions(+):
README.md
README_zh.md
docs/README.md
docs/en/sharded-snapshotdb.md
docs/zh/sharded-snapshotdb.md
src/pt_snap_cli/core/dataset_contract.py
tests/test_dataset_contract.py
🔗 Related Issue
Refs #198 — deliberately no auto-closing keywords; the issue stays open because GUI/C++/installed-wheel acceptance is human-deferred.
Review comment: #198 (comment)
🧪 Testing
Manually verified the bilingual guides, the immutable upstream blob links and the docs governance rules; no runtime behavior is claimed beyond the contract tests.
✅ Checklist
"No new warnings" keeps the pre-existing external pytest-asyncio startup deprecation and existing informational type warnings unchanged rather than hidden;
ResourceWarning/PytestUnraisableExceptionWarningremain errors.Snapshot Runtime Provenance
No snapshot runtime files change in this PR, so no provenance declaration is required.
📸 Screenshots (if applicable)
Not applicable — no user-interface or C++ changes in this PR.
📋 Additional Notes
main, so the Test workflow (snapshot provenance, lint, Python 3.10–3.13 matrix with coverage floors, 3.13 wheel build/audit/clean-wheel acceptance) runs for head9e17e73.Head SHA:
9e17e734a205eb2658f97475353379e2f7af4a02; branchfix/issue-198-09244150. All checks above were recorded locally on this exact head; the C++/GUI consumer and installed-wheel profile remain untested and unclaimed.