Repository navigation
Conversation
- Remove unused pydantic dependency from pyproject.toml (#15) - Fix bool converter bug: "false" string now returns False instead of True (#12) - Replace silent pass with warnings in template loading (#13) - Use strict=True in zip() to catch column count mismatches early (#16) - Split broad except Exception in CLI use command (#16) - Fix CLAUDE.md template naming mismatch - Add test coverage for bool converter, mapper KeyError, execute_on_all_devices (#17) Closes #12, #13, #14, #15, #16, #17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Fix 7 code quality issues identified during code review and close test coverage gaps:
pydanticdependency — listed inpyproject.tomlbut never imported anywhere in the source"false"string was returningTrue(non-empty string truthiness); now usesx.lower() in ("true", "1", "yes")in bothconfig.pyandmapper.pyexcept Exception: passwithwarnings.warn()inregistry.pyandexecutor.pyzip()strictness — changedstrict=Falsetostrict=Trueinexecutor.pyto catch column count mismatches earlyexcept Exceptioninusecommand into specificDatabaseNotFoundError/SchemaVersionError+ fallback*_v2suffix to match actual filenames (e.g.,leak_detectionnotleak_detection_v2)KeyErrorpropagation, andexecute_on_all_devices🔗 Related Issue
Fixes #12, #13, #14, #15, #16, #17
🧪 Testing
✅ Checklist
📸 Screenshots (if applicable)
N/A — no UI changes
📋 Additional Notes
pyproject.tomlquery/config.py,query/mapper.pywarnings.warn()query/registry.py,query/executor.pystrict=Truecli.py,query/executor.pytests/query/test_config.py,test_mapper.py,test_executor.pyNote: Issue #14 (QueryBuilder HAVING) is noted but not included in this PR as it requires new functionality rather than a bug fix — recommended as a follow-up PR.