Repository navigation
fix(snapshot): recognize PEP 604 optional SQLite types - #173
Merged
Merged
Conversation
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Recognize
types.UnionTypealongsidetyping.Unionin SQLite type mapping, soT | Noneuses the same affinity asOptional[T]. Update the helper/column annotations to accept PEP 604 unions.Replace the existing strict xfail with regression coverage for all five supported scalar types, reversed optional order, ambiguous unions and unsupported types. An in-memory SQLite test verifies generated column affinities, numeric ordering and nullable value round trips. Append the local modification to snapshot provenance.
🔗 Related Issue
Refs #165. Partially addresses its PEP 604 mapping item; keep the umbrella issue open. Independent of lifecycle PR #171 and based directly on main at c85a357.
🧪 Testing
✅ Checklist
Snapshot Runtime Provenance
Snapshot provenance decision: updated
📋 Additional Notes
Multiple non-None union members and unsupported types retain the existing TEXT fallback. Existing databases are not migrated. The remaining coverage, type-warning and CLI refactoring items in #165 are separate work.