Repository navigation
fix(skills): unify diagnostic prerequisite probes - #172
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
capabilities --json+overview <db> --json, with identical bundled copies.overview.import_metadata.statuseven when the command succeeds withok: true. Stop on invalid metadata/schema errors; continue on legacyunavailable/metadata_missingwith unknown provenance recorded.🔗 Related Issue
Fixes #162
🧪 Testing
All Python checks used
/Users/test1/liuyekang/miniconda3/bin/python, from the worktree root, withPYTHONPATH=<worktree>/src. Pytest used an isolated temporary HOME while preserving original site-package paths; no editable install was performed.pytest -q: 1041 passed, 1 xfailed, including alltests/skills, bundled tests, CLI/JSON/API contracts, and runtime suites.python -m ruff check .: passed.python -m black --check .: passed (156 files).python -m basedpyright --pythonpath /Users/test1/liuyekang/miniconda3/bin/python: 0 errors, 831 informational warnings in unchanged Python package sources.git diff --check: passed.Measured synthetic-DB discovery (two calls, excluding availability/focus/report help): 55,683 bytes per diagnostic. Additional redundant metadata/per-template probes would add 9 calls / 23,671 bytes for the leak required list, 5 / 14,473 for peak, and 5 / 13,803 for fragmentation. These are measured payload sizes, not a claim that the cold full catalog is smaller than individual probes. Reuse decisions are covered by static skill contracts, not live model execution. The existing pytest-asyncio environment emits its unset loop-scope deprecation warning.
✅ Checklist
Snapshot Runtime Provenance
Snapshot provenance decision: no-update
Snapshot provenance no-update reason: Only skill Markdown and skill contract tests change; no snapshot runtime code, executable fixture, or provenance evidence changes.
📸 Screenshots (if applicable)
Not applicable.
📋 Additional Notes
origin/mainatc85a357; one issue-specific commit.pt-snap skill listreports statusmissingafter--dirinstall, blocking helper routing #159), leak skill/bundled copy and its contract test (leak_detectionhas nooffsetparameter — Step 2 paging advice can yield 20x incorrect totals #160/Step 4 requires identity matching, but the prescribed template returns no block id #161/Determine the iteration count before classifying a per-step leak #164), peak skill/bundled copy and its contract test (Capabilities doc says[missing callstack], but the template returns an empty string #163). Changes are confined to preflight and a peak interpretation reference that otherwise demanded another template-info call. Leak Steps 2/4/7 and the existing required-template-list line are untouched; the latter remains easy to extend for Step 4 requires identity matching, but the prescribed template returns no block id #161.