Repository navigation
fix(skills): require iteration evidence before per-step leak conclusions - #170
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Require trusted iteration evidence before either positive or negative per-step leak conclusions in
pt-snap-memory-leakStep 7, the output template, and the verification checklist.unknown.🔗 Related Issue
Fixes #164
🧪 Testing
Used
/Users/test1/liuyekang/miniconda3/bin/python, worktree-root CWD, isolated HOME, and explicit worktreesrcplus original site-package paths inPYTHONPATH. Confirmedpt_snap_cli.__file__resolves inside this worktree. No editable install or shared-environment changes.python -m pytest tests/test_fixture_provenance.py— 7 passed.python -m pytest tests/skills/test_memory_leak_iterations_contract.py tests/skills/test_memory_leak_contract.py tests/test_bundled_skills.py— 36 passed.python -m pytest tests/skills tests/test_bundled_skills.py— 120 passed.python -m tests.skills validate tests/skills/suites/pt-snap-memory-leak-iterations/suite.yaml— all four cases/branches valid.python -m ruff check .andpython -m black --check .— passed.python -m basedpyright --pythonpath /Users/test1/liuyekang/miniconda3/bin/python— 0 errors, 831 informational warnings in unchanged package source.git diff --check— passed.Evaluation limitation: no live model/agent evaluation was run. Validation covers descriptor/schema loading, generated SQLite fixture queries, and deterministic oracle/grader behavior only; it does not establish actual model adherence. Pytest emitted the installed pytest-asyncio plugin's unset-loop-scope deprecation warning.
✅ Checklist
Snapshot Runtime Provenance
Snapshot provenance decision: no-update
Snapshot provenance no-update reason: Changes are limited to skill instructions and declarative synthetic skill evaluations/tests; no snapshot runtime files or executable snapshot fixtures changed.
📸 Screenshots (if applicable)
Not applicable.
📋 Additional Notes
origin/mainatc85a357; branch:fix/issue-164-iteration-evidence.skills/pt-snap-memory-leak/SKILL.mdandsrc/pt_snap_cli/bundled_skills/pt-snap-memory-leak/SKILL.md. This PR changes Step 7/output/checklist only; Step 2 (leak_detectionhas nooffsetparameter — Step 2 paging advice can yield 20x incorrect totals #160), Step 4 (Step 4 requires identity matching, but the prescribed template returns no block id #161), and preflight (pt-snap-helperand the diagnostic skills contradict each other on prerequisite probing #162) are untouched.