Repository navigation
fix(skills): use bounded replacement windows for leak candidates - #169
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Correct the leak skill Step 2 and both querying guides to match the current
leak_detectioncontract. The latest issue review confirms that unsupportedoffsetalready fails rather than silently repeating rows.limit.-n 0, and report incomplete coverage when the complete set exceeds the budget.has_moredoes not imply offset support. Keep unknown-parameter rejection and the existing result schema intact.🔗 Related Issue
Fixes #160
🧪 Testing
Run from this worktree with
/Users/test1/liuyekang/miniconda3/bin/python, itssrcfirst inPYTHONPATH, the original user site preserved, and an isolatedHOMEfor pytest. Verified the package imports from this worktree; no editable install was changed.tests/test_fixture_provenance.py: 7 passed in the initial focused run before any deserializing suite.python -m pytest tests/test_leak_query_window.py -q: 7 passed.python -m pytest -q: 1031 passed, 1 xfailed, including alltests/skills, bundled-skill parity, query, CLI/API, and runtime suites.python -m ruff check .: passed.python -m black --check .: passed (156 files unchanged).python -m basedpyright --pythonpath /Users/test1/liuyekang/miniconda3/bin/python: 0 errors, 831 informational warnings in unchanged package Python sources.git diff --check: passed.The shared environment emits a pytest-asyncio unset-loop-scope deprecation warning. No live external-agent evaluation or large production snapshot run was performed; the workflow regressions use deterministic SQLite data.
✅ Checklist
Snapshot Runtime Provenance
Snapshot provenance decision: no-update
Snapshot provenance no-update reason: Only leak skill text, querying guides, and an independent synthetic-SQLite test file changed; no snapshot runtime or executable fixture changes.
📸 Screenshots (if applicable)
Not applicable.
📋 Additional Notes
Based on
origin/mainatc85a357. Only Step 2 changes in the source and bundled leak skill; Step 4 (#161), Step 7 (#164), and prerequisites (#162) are outside this PR. Those parallel fixes may touch the same two skill files in different sections. The new test file avoids modifying shared test modules. No pagination fields or implementation added.