Repository navigation
fix(skills): match complete peak and final block identities - #168
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
active_blocks_at_eventqueries at the active peak and final event to source and bundled leak Step 4, and include the template in the capability checklist.(id, allocEventId)within the same database/device. Collect each event from offset 0 untilhas_more=false; explain why terminal offset pages can still havetruncated=true.🔗 Related Issue
Fixes #161
🧪 Testing
Using
/Users/test1/liuyekang/miniconda3/bin/pythonandPYTHONPATH=<worktree>/src; verified the imported package path. No editable reinstall.pytest tests/skills tests/test_bundled_skills.py tests/query tests/core/test_skill_service.py -q: 383 passed.pytest -qwith isolated temporary HOME and retained existing user-site path: 1029 passed, 1 xfailed.ruff check .andblack --check .: passed.basedpyright --pythonpath /Users/test1/liuyekang/miniconda3/bin/python: 0 errors, 831 informational warnings in unchanged source.✅ Checklist
Snapshot Runtime Provenance
Snapshot provenance decision: no-update
Snapshot provenance no-update reason: Only leak skill instructions and synthetic/static tests changed; no snapshot runtime files or executable fixtures changed.
📸 Screenshots (if applicable)
Not applicable.
📋 Additional Notes
Based on origin/main c85a357. Aggregate template semantics are unchanged. Peak-breakdown already uses active_blocks_at_event; this fixes the missing leak Step 4 procedure.
Potential parallel-work overlap: source/bundled leak SKILL.md and tests/skills/test_memory_leak_contract.py (#160/#162/#164), plus tests/query/test_peak_memory_templates.py (#163). Skill edits touch Step 4 and only add one required-template catalog item; Step 2, Step 7, output iteration rules, and other preflight text are unchanged. Query tests are appended without reorganizing existing tests.