Skip to content

fix(skills): distinguish scoped availability from host loading - #167

Merged
codeasier merged 1 commit into
mainfrom
fix/issue-159-skill-availability
Oct 3, 2026
Merged

codeasier merged 1 commit into
mainfrom
fix/issue-159-skill-availability

Conversation

@codeasier

Copy link
Copy Markdown
Owner

📝 Description

  • Clarify that default skill-list status covers inspected built-in locations; custom installs are rechecked with the same --dir.
  • Update the helper availability instructions and bundled copy to distinguish on-disk status, catalog readability, and host loading. Already loaded skills can receive a handoff despite default missing; unavailable or known-outdated active copies receive explicit next steps.
  • Keep the helper read-only and report scope/status/loading evidence separately. Synchronize English and Chinese skill guides.
  • Add executable CLI regressions for all six custom-installed skills and installed/outdated/missing states, plus static handoff contracts.

🔗 Related Issue

Fixes #159

🧪 Testing

  • Tests added/updated
  • Manual testing completed

All commands ran from the isolated worktree with /Users/test1/liuyekang/miniconda3/bin/python and PYTHONPATH=$PWD/src; verified package imports resolve to this worktree.

  • Fixture provenance + original helper/bundled baseline: 15 passed (provenance ran before any deserializing suite).
  • Red regression: 7 missing-instruction contracts failed before the fix; 3 executable scoped-list scenarios passed, confirming the CLI already behaves correctly.
  • Focused helper, availability, bundled, skill-service and CLI skill checks: 62 passed, 87 deselected.
  • Full python -m pytest including tests/skills and bundled tests: 1034 passed, 1 xfailed.
  • python -m ruff check .: passed.
  • python -m black --check .: passed, 156 files unchanged.
  • python -m basedpyright --pythonpath /Users/test1/liuyekang/miniconda3/bin/python: 0 errors, 831 informational warnings.
  • git diff --check: passed.

Limitations: no live agent-host loading evaluation was run. Host-loading decisions are covered by skill contracts; actual CLI install/list behavior is exercised with isolated temporary home/project/custom directories. The environment emitted the existing pytest-asyncio unset-loop-scope deprecation warning.

✅ Checklist

  • Code follows project guidelines
  • Documentation updated (if applicable)
  • No new warnings introduced
  • Changes tested locally

Snapshot Runtime Provenance

  • Snapshot provenance evaluation completed when snapshot runtime files change
    Snapshot provenance decision: no-update
    Snapshot provenance no-update reason: Only helper skill instructions, their packaged copy, skill documentation, and availability tests changed; no snapshot runtime files changed.

📸 Screenshots (if applicable)

Not applicable.

📋 Additional Notes

Based on origin/main at c85a357. The helper edits are confined to the availability section, preserving the prerequisite probe text being handled for #162. Potential overlapping files with that work are skills/pt-snap-helper/SKILL.md and src/pt_snap_cli/bundled_skills/pt-snap-helper/SKILL.md. CLI fields and directory registration behavior are unchanged.

@codeasier
codeasier merged commit cba88f6 into main Oct 3, 2026
6 checks passed
@codeasier
codeasier deleted the fix/issue-159-skill-availability branch October 3, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pt-snap skill list reports status missing after --dir install, blocking helper routing

1 participant