Skip to content

fix(skill): uninstall every copy that skill list reports - #150

Merged
codeasier merged 2 commits into
mainfrom
fix/149-skill-uninstall-listed-copies
Sep 19, 2026
Merged

codeasier merged 2 commits into
mainfrom
fix/149-skill-uninstall-listed-copies

Conversation

@codeasier

Copy link
Copy Markdown
Owner

📝 Description

Unfiltered pt-snap skill uninstall now removes every bundled-skill copy that pt-snap skill list would report as installed or outdated. --target / --project / --dir still limit destinations, and the Python uninstall_skills() default remains the install destinations.

🔗 Related Issue

Fixes #149

🧪 Testing

  • Tests added/updated
  • Manual testing completed

Focused checks in worktree .worktrees/issue-149 with conda pt-snap and PYTHONPATH=src:

  • pytest tests/core/test_skill_service.py tests/test_cli.py tests/skills/test_helper_contract.py -k skill (45 passed)
  • ruff check and black --check on the changed Python files

Manual check: pt-snap skill uninstall pt-snap-setup removed cursor:user plus project agents/claude copies that list had shown as installed.

✅ Checklist

  • Code follows project guidelines
  • Documentation updated (if applicable)
  • No new warnings introduced
  • Changes tested locally

Snapshot Runtime Provenance

  • Snapshot provenance evaluation completed when snapshot runtime files change
    Snapshot provenance decision: no-update
    Snapshot provenance no-update reason: This PR only changes skill uninstall CLI/service behavior, tests, and docs; src/pt_snap_cli/snapshot/ is untouched.

📋 Additional Notes

Python SkillService.uninstall_skills() without all_locations=True still targets user-level agents and claude, matching default install.

codeasier added 2 commits September 19, 2026 01:54
Unfiltered uninstall only checked default user-level agents/claude
destinations, so cursor and project copies stayed installed.
Docs overstated that every listed copy is removed, all_locations ignored
an explicit project scope, and mixed-name reports dropped missing skills.
@codeasier
codeasier merged commit 185def4 into main Sep 19, 2026
6 checks passed
@codeasier
codeasier deleted the fix/149-skill-uninstall-listed-copies branch October 3, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] pt-snap skill uninstall 未删除 skill list 显示为 installed 的副本

1 participant