Repository navigation
fix(skill): uninstall every copy that skill list reports - #150
Merged
Merged
Conversation
added 2 commits
September 19, 2026 01:54
Unfiltered uninstall only checked default user-level agents/claude destinations, so cursor and project copies stayed installed.
Docs overstated that every listed copy is removed, all_locations ignored an explicit project scope, and mixed-name reports dropped missing skills.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Unfiltered
pt-snap skill uninstallnow removes every bundled-skill copy thatpt-snap skill listwould report as installed or outdated.--target/--project/--dirstill limit destinations, and the Pythonuninstall_skills()default remains the install destinations.🔗 Related Issue
Fixes #149
🧪 Testing
Focused checks in worktree
.worktrees/issue-149with condapt-snapandPYTHONPATH=src:pytest tests/core/test_skill_service.py tests/test_cli.py tests/skills/test_helper_contract.py -k skill(45 passed)ruff checkandblack --checkon the changed Python filesManual check:
pt-snap skill uninstall pt-snap-setupremovedcursor:userplus projectagents/claudecopies thatlisthad shown as installed.✅ Checklist
Snapshot Runtime Provenance
Snapshot provenance decision: no-update
Snapshot provenance no-update reason: This PR only changes skill uninstall CLI/service behavior, tests, and docs;
src/pt_snap_cli/snapshot/is untouched.📋 Additional Notes
Python
SkillService.uninstall_skills()withoutall_locations=Truestill targets user-levelagentsandclaude, matching default install.