Repository navigation
feat: remove MCP support and drop the mcp dependency - #146
Merged
Merged
Conversation
Close the MCP product surface so default installs no longer pull mcp, starlette, or uvicorn. Keep SnapshotAnalyzer and rewrite the CLI/API contract tests without changing API defaults.
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Remove the MCP product surface as a 0.x breaking change: delete
src/pt_snap_cli/mcp/, thept-snap-mcpentry point, and the coremcpdependency. Agent integration is skills + CLI only.SnapshotAnalyzeris unchanged (get_template_info()still returnsNonefor missing templates;execute_query()still defaults tomax_rows=None).CLI/API contract tests are rewritten as
tests/test_contract_cli_api.py(not deleted), covering focus/callstack_layout, template list/info/choices,leak_detection, v1 inline callstack, missing focus/template (CLI exit 1), unknown params, illegalchoices, and metadata JSON.🔗 Related Issue
Fixes #137
🧪 Testing
Tests added/updated
Manual testing completed
pytest tests/test_contract_cli_api.py tests/test_package.py tests/test_governance.py tests/test_api.py tests/test_snapshot_analyzer_cache.py tests/test_query_cache_perf.py tests/test_release_workflow.pyFull suite: 898 passed, 1 xfailed
ruff check .and basedpyright (0 errors)Clean wheel install in a fresh venv: console script is only
pt-snap; freeze has nomcp/starlette/uvicorn;pt-snap --helpandSnapshotAnalyzerwork✅ Checklist
Snapshot Runtime Provenance
Snapshot provenance decision: no-update
Snapshot provenance no-update reason: This PR does not change src/pt_snap_cli/snapshot/**; it only removes the MCP adapter, packaging, docs, and CLI/API contract tests.
📋 Additional Notes
CHANGELOG records this as 0.4.0 Unreleased. Historical MCP changelog entries are kept. setuptools-scm remains
0.3.0.post1.devNuntilv0.4.0is tagged.