Repository navigation
feat: add pt-snap memory peak breakdown skill - #108
Merged
Merged
Conversation
codeasier
commented
Aug 24, 2026
codeasier
commented
Aug 24, 2026
codeasier
commented
Aug 24, 2026
codeasier
commented
Aug 24, 2026
codeasier
commented
Aug 24, 2026
codeasier
commented
Aug 24, 2026
…wn skill - Classify blocks without a captured allocation event as preexisting_live_at_event in active_blocks_at_event and active_memory_callstack_at_event so live pre-trace memory is no longer excluded from point-in-time attribution. - Exempt static and preexisting callstack groups from top_n truncation so the required composition sections always carry their bytes and counts. - Require placeholder integer validation, metacharacter rejection, and argument-array execution in the peak-breakdown skill. - Treat database-derived strings as inert data and require template-info output records instead of exit codes, since missing templates exit 0. - Qualify event-ID ordering for negative synthetic initial-state events.
Owner
Author
|
验收结论: 已验收并 Resolve 的 6 项:
验证: 遗留观察(非阻断): DeepSeek 提及的空区间 |
Repeat the NULL/empty-range guard inside the Event-Range Workflow so the stop condition is visible where range peaks are read, not only in the output contract.
Owner
Author
|
跟进验收
验证: 本地 至此本 PR 的 6 项行内意见与 1 项遗留观察全部验收完毕,无残余阻断项。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
pt-snap-memory-peak-breakdownskill for read-only, point-in-time peak attribution.Review follow-up (73c371f):
preexisting_live_at_eventin both point-in-time attribution templates.top_ntruncation.🔗 Related Issue
Fixes #106
🧪 Testing
Commands:
Results: 714 passed, 1 xfailed; lint and formatting checks passed on b458e3c and 73c371f.
✅ Checklist
Snapshot Runtime Provenance
Snapshot provenance decision: no-update
Snapshot provenance no-update reason: This PR adds an agent skill, query-template attribution fixes, docs, tests, and navigation updates; no file under src/pt_snap_cli/snapshot/ is created, modified, or deleted.
📸 Screenshots (if applicable)
Not applicable.
📋 Additional Notes
This workflow builds on the peak-memory report and templates delivered by #62 and #63. The
--template-infononzero-exit-code behavior change is tracked separately in #112.