Repository navigation
Exercise reusable rust-skills2 strict gate - #73
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Real-world validation and adoption of the reusable rust-skills2 strict nightly-Clippy gate.
Besides adding the reusable workflow job, this removes policy debt exposed by the gate: handwritten
.expect()/.unwrap()/explicit panic exemptions, broad#[allow]sites, test-only unsafe environment mutation, and several avoidable lint suppressions. Tests propagate errors or assert directly; benchmark setup exits with an explicit diagnostic; configuration tests inject an environment source map; framework/generated-code exceptions stay narrowly documented.The workflow still points at the rust-skills2 feature branch while PR 95 is under validation; after the shared gate lands it can be switched to
@main.