Repository navigation
Make gateway auth logout clear session state - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Login establishes both a Bearer/refresh-token identity and a server-side cookie session, but
/auth/logoutpreviously revoked only refresh-token state. That allowed/auth/logoutto return success while the same client remained authenticated through/session/whoami.This change makes
/auth/logoutthe unified logout path:/auth/logoutresponse, flush the current server-side session in authenticated-route middleware/auth/logout-> old session cookie is invalid and old refresh token is rejected/session/logoutremains available as the session-only endpoint;/auth/logoutis the endpoint that tears down the credentials established together by/auth/login.CI validation is green, including native Clippy, the full browser/integration suite, the unified logout regression, existing SQLx OpenTelemetry parenting coverage, production builds, and all Docker images.