Repository navigation
Instrument live-search SQLx queries with OpenTelemetry - #4
Merged
Merged
Conversation
codeandsolder
force-pushed
the
deps/sqlx-otel-0.5
branch
from
August 28, 2026 15:20
293dedf to
c414081
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade
sqlx-otelfrom the dormant SQLx-0.8-era 0.3 line to released 0.5.0 and enable it in live-search'sotelfeature.Implementation:
sqlx-otel0.5, matching SQLx 0.9, OpenTelemetry 0.32, and Rust 1.94sqlx_otel::Pool<Postgres>whenotelis enabledPgPool; readiness deliberately bypasses instrumentation to avoid probe-span noiseMeterProvideris installed, sosqlx-otel's optional runtime pool metrics are not enabled, and the Axum Prometheus layer remains a separate metrics pipelineSKILL.mdto describe the active integrationCLIENTspan is emitted and is correctly parented beneath an activetracing-opentelemetryspanThe normal deployment Dockerfile still builds the default
ssrfeature set;otelremains an explicitly optional deployment feature.Query annotations/nicer semantic operation names are intentionally not part of this dependency/instrumentation activation change; the integration still exposes SQL text and can add application-specific annotations separately.
Draft until the updated CI matrix, including the runtime span-parenting test, is green.